Fix #11117 #11147
Merged
Fix #11117 #11147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm confused, how did backporting an error message change make an assert no longer applicable? |
|
I don't think it's that the first change causes the second, it's that the backport got the cosmetic part of the fix but not the actual fix? |
|
@tkelman, you are right. Also, I realized there is potentially an unsafe branch if someone tried to redefine a non-generic with keyword args. Will update this later to |
|
Updated. |
|
That makes more sense to me, thanks. |
|
Guess this could've used a test too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's croaking here.
We backported 97381df (fix for #9773) which gives the nice error message,
but didn't remove the related assert, which was removed in 2604610.
I think this is safe to remove, but I don't have a 0.3 build handy. cc @tkelman