Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests and bug-fix for linalg/bitarray.jl #11144

Merged
merged 1 commit into from
May 6, 2015
Merged

Tests and bug-fix for linalg/bitarray.jl #11144

merged 1 commit into from
May 6, 2015

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented May 5, 2015

Fixes a game-breaking bug in findmin where it was trying to return a variable that didn't exist, introduced in 11def49. Also added tests for untested methods on bitarrays.

@jiahao
Copy link
Member

jiahao commented May 5, 2015

oops

@kshyatt kshyatt mentioned this pull request May 6, 2015
Merged
@tkelman
Copy link
Contributor

tkelman commented May 6, 2015

Is the bug also present on release-0.3?

@kshyatt
Copy link
Contributor Author

kshyatt commented May 6, 2015

I just checked v0.3.8 and yes, it is present there. Also present in 0.3.5.

jakebolewski added a commit that referenced this pull request May 6, 2015
@jakebolewski
Merge pull request #11144 from kshyatt/bitarray
910572d 
Tests and bug-fix for linalg/bitarray.jl
@jakebolewski jakebolewski merged commit 910572d into JuliaLang:master May 6, 2015
@kshyatt kshyatt deleted the bitarray branch May 8, 2015 07:06
tkelman pushed a commit that referenced this pull request May 9, 2015
@kshyatt @tkelman
Tests and bug-fix for linalg/bitarray.jl
7fe8d2c 
(cherry picked from commit 12f4404)
ref PR #11144

findmax and findmin on an empty bitarray throw
ErrorException instead of ArgumentError on release-0.3

bitrand was called randbool on release-0.3
@tkelman
Copy link
Contributor

tkelman commented May 9, 2015

backported a lightly modified version of this in 7fe8d2c - also for the sake of conflict resolution I backported #10375 too while I was at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kshyatt @jiahao @tkelman @jakebolewski