Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for untested symmetric/Hermitian operations #11129

Merged
merged 1 commit into from
May 5, 2015

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented May 4, 2015

Again going by my Coveralls, several methods in base/linalg/symmetric.jl were untested. I added tests for:

  • issym
  • ishermitian
  • full
  • transpose, ctranspose
  • matrix * vector multiplication
  • matrix * matrix when both are Symmetric or Hermitian
  • A \ x when A is Symmetric or Hermitian
  • Inversion

Again, if any tests are duplicates, I'm happy to remove them.

@tkelman
Copy link
Contributor

tkelman commented May 4, 2015

This is great, keep up the good work!

Can any of the second block be tested when eltya == BigFloat ?

@kshyatt
Copy link
Contributor Author

kshyatt commented May 4, 2015

Is my <: Real not catching BigFloat? It should work with that type. Give me a moment to check that it does.

@tkelman
Copy link
Contributor

tkelman commented May 4, 2015

There's a pre-existing line eltya == BigFloat && continue # Revisit when implemented in julia between the first block you're adding and the second block

@kshyatt
Copy link
Contributor Author

kshyatt commented May 4, 2015

Apparently not. eigfact doesn't like BigFloat.

@tkelman
Copy link
Contributor

tkelman commented May 4, 2015

Right, not yet, but full, transpose, and hopefully some or all of the multiplication tests you're adding could be moved to before the eltya == BigFloat && continue so they get run for BigFloat?

@kshyatt
Copy link
Contributor Author

kshyatt commented May 4, 2015

Ok, I checked and everything below mat * vec doesn't work with BigFloat. I'll update the PR.

@tkelman
Copy link
Contributor

tkelman commented May 4, 2015

Cool, thanks for checking. May be some FIXMEs here.

@@ -50,6 +75,34 @@ let n=10
let A = a[:,1:5]*a[:,1:5]'
@test rank(A) == rank(Hermitian(A))
end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

picky whitespace complaint here

@kshyatt
Copy link
Contributor Author

kshyatt commented May 4, 2015

Ok hopefully that clears it

@ViralBShah
Copy link
Member

@kshyatt It may help to have an account on julia.mit.edu for parallel testing - 80 cores. If it would help, email me and I will set it up.

tkelman added a commit that referenced this pull request May 5, 2015
Added tests for untested symmetric/Hermitian operations
@tkelman tkelman merged commit 51ef880 into JuliaLang:master May 5, 2015
@kshyatt kshyatt deleted the symmtests branch May 5, 2015 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants