Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Char: delete bitwise operator methods for Char type #11128

Merged
merged 2 commits into from
May 6, 2015
Merged

Conversation

StefanKarpinski
Copy link
Sponsor Member

Alternative to #11103 – just delete them all.

@nalimilan
Copy link
Member

+1, but probably a deprecation phase wouldn't hurt?

@StefanKarpinski
Copy link
Sponsor Member Author

Yes, was going to add those pending the outcome of the discussion on #11103. Also, it's kind of good to go through CI without deprecations first to make sure you didn't miss any usages in tests that are hidden by having the deprecation definitions. It's happened a few times that we've discovered lingering usages that only break when we delete the deprecations.

@tkelman
Copy link
Contributor

tkelman commented May 5, 2015

Also, it's kind of good to go through CI without deprecations first to make sure you didn't miss any usages in tests that are hidden by having the deprecation definitions

Good idea. Best to mark as WIP at that stage then?

@jakebolewski
Copy link
Member

+1, retaining these was an oversight of makingChar !<: Integer.

@ScottPJones
Copy link
Contributor

@StefanKarpinski What all does CI do, in addition to Base.runtests()? I've been always doing that before pushing to GitHub... and I already had done Base.runtests() with all of the bitwise operators totally removed... Thanks!

@StefanKarpinski
Copy link
Sponsor Member Author

It does that but on many platforms. Probably overkill in this case, admittedly.

@ScottPJones
Copy link
Contributor

Could you merge this in to Base, and then close #11103? Since this handles the not logical bitwise operations that I'd removed as part of #11103, I'm happy to just leave it at that...

StefanKarpinski added a commit that referenced this pull request May 6, 2015
Char: delete bitwise operator methods for Char type
@StefanKarpinski StefanKarpinski merged commit 0459be9 into master May 6, 2015
@tkelman tkelman deleted the sk/charops branch May 6, 2015 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants