Fix Windows XP macro #11018
Merged
Fix Windows XP macro #11018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was originally added in 37b8f25 by @kmsquire. Would appreciate some review that my redone version looks okay (I tested that it gives the expected behavior on xp and windows 7), I'd like to get this fix into 0.3.8 within a few days, and best to have things on master for a little while before that. |
|
comment from c3bec707#commitcomment-10908088, now hidden due to a rebase
No, I don't think there are. We might want to quantify that somehow if we hit a technical issue that would be too much effort to get working on XP (possibly libgit2-related), but for now if support can be maintained without trouble I don't see why not to keep it alive. |
the previous version of this macro was hard-coding the result of windows_version() from the build machine, and the buildbots are all newer than XP so this was not working correctly
repl tests freeze otherwise, the fix in libuv for #7082 does not work on XP dllist tests also fail on xp since oddly Libdl.dllist() is only listing file names, not full absolute paths udp recvfrom tests give ERROR: LoadError: bind: address family not supported (EAFNOSUPPORT)
tkelman
force-pushed
the
tk/fix-windowsxp_only
branch
from
c4ffd01
to
8cf5881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We probably want to get rid of this macro, along with XP support, at some point. But for now we use it in a handful of places, mostly related to symlinks.
The current implementation is actually broken, since the Windows version check was getting run at system image compile time on the build machines (building Julia from source on XP doesn't work, something in LLVM failed to link IIRC from the last time I tried) instead of at runtime.