RFC: Show the PID of each worker when running under valgrind #11013
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When valgrind outputs any warning/error messages, it does so along with a banner of the
getpid()
that the error is coming from. This is immensely helpful when working to debug programs that fork multiple processes.This patch causes each such julia worker process to output the
getpid()
of the worker when the worker starts (but only when running under valgrind). This allows a person to determine which worker number each error/warning comes from. For instance, given the following (schematic) output, it is now possible to determine that the "invalid read" warning is due to thelinalg1
tests.I put this patch where I thought it would fit, but I'd be happy to move it if there's a better place.