Improve performance of length on UTF8String #11011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrote the u8_charnum function to improve the speed of getting the length of a UTF-8 string.
(in my tests, it was approximately twice as fast as using u8_charnum, and many times faster than
the old approach using u8_strlen [which should be removed, along with u8_strwidth, because if called with a malformed string without a terminating \0, they can overrun the buffer, potentially causing an access violation])