Document and improve consistency of linearindexing #10859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always have array subtypes define `linearindexing` in the type-domain, so they do not need to have two definitions.
6 tasks
|
👍 |
mbauman
added a commit
that referenced
this pull request
Apr 17, 2015
Document and improve consistency of linearindexing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always have array subtypes define
linearindexingin the type-domain, so they do not need to have two definitions.Cc: @timholy
While it's complicated to define this in the type domain (due to invariance), I think this is better than making abstract array authors define both value- and type-domain methods.
Also, this help definition doesn't work at the REPL due to #10721, but documented is better than not.