Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vi editor should work w/line numbers #10771

Merged
merged 1 commit into from
Apr 8, 2015

Conversation

PallHaraldsson
Copy link
Contributor

This should disable "Unknown editor: no line number information passed." warning.

This should disable "Unknown editor: no line number information passed." warning.
@PallHaraldsson
Copy link
Contributor Author

I started over as it seems I managed to "amend", but it seems I amended the wrong commit! Make sure only this commit gets merged. That is probably what will happen, I'm just new to this and not sure if the previous error will screw things up.. (Or my own repository, will try to find out how to reset it just in case..).

Should I add a backport label?

@PallHaraldsson
Copy link
Contributor Author

See old one #10656

@pao
Copy link
Member

pao commented Apr 8, 2015

This PR looks correct. The other one won't affect it (and I've also now closed it so it won't be accidentally merged.)

JeffBezanson added a commit that referenced this pull request Apr 8, 2015
vi editor should work w/line numbers
@JeffBezanson JeffBezanson merged commit 961bc33 into JuliaLang:master Apr 8, 2015
@tkelman
Copy link
Contributor

tkelman commented Apr 8, 2015

I don't see any reason against backporting this (or the similar #10012).

@PallHaraldsson PallHaraldsson deleted the patch-4 branch April 9, 2015 08:32
tkelman pushed a commit that referenced this pull request Apr 16, 2015
This should disable "Unknown editor: no line number information passed." warning.
(cherry picked from commit 0fab858)
ref PR #10771
@tkelman
Copy link
Contributor

tkelman commented Apr 16, 2015

backported in b9406cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants