fix spdiagm to promote all the element types #10590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the first element type
|
Failure is unrelated. |
ViralBShah
added a commit
that referenced
this pull request
Mar 21, 2015
fix spdiagm to promote all the element types
|
I usually like to have things on master for a little longer before backporting them, but all sorts of things are broken on 0.4 right now and this seems harmless enough. Backported in 9cc3666 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
spdiagm(B, ...)was just using theeltypeofB[1], rather than promoting all of the eltypes. I noticed this today when I tried to create a sparse matrix where one diagonal was real and another was complex, and it threw anInexactError. (cc @oskooi)