Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #10318 #10398

Merged
merged 1 commit into from
Mar 4, 2015
Merged

fixes #10318 #10398

merged 1 commit into from
Mar 4, 2015

Conversation

amitmurthy
Copy link
Contributor

Closes #10318

@@ -9,7 +9,7 @@ function launch(manager::UnixDomainCM, params::Dict, launched::Array, c::Conditi
for i in 1:manager.np
sockname = tempname()
try
cmd = `$(params[:exename]) --worker=custom $(@__FILE__) worker $sockname`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakebolewski - sometime the workers were launched with "worker" option set as default (and this was responsible for #10318) . I suspect it to be due to the second "worker" argument towards the end. Do you think this is a possibility with the way getopt_long works?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the filename have a "-" character in it? Do you have any examples of what the arguments were that caused this to happen?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. And I don't have the actual args printed either. The command would have been something like

home/bezanson/src/julia/usr/bin/julia --worker=custom /home/bezanson/src/julia/usr/share/doc/julia/examples/clustermanager/simple/UnixDomainCM.jl worker /tmp/juliaxHYvd3

amitmurthy added a commit that referenced this pull request Mar 4, 2015
@amitmurthy amitmurthy merged commit 31c12af into JuliaLang:master Mar 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnixDomainCM test often fails
2 participants