Fixes error: undefined reference to `JL_PRINTF' see: https://github.com/... #10372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #10371 seems that some time ago `JL_PRINTF' was removed and `DLLEXPORT int jl_printf(uv_stream_t *s, const char *format, ...);` is used instead Cheers P
|
Thanks, this looks good to me. I assume you tested this version and things worked fine? |
|
@tkelman Thanks |
tkelman
added a commit
that referenced
this pull request
Mar 1, 2015
Fixes error: undefined reference to `JL_PRINTF' see: https://github.com/...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.../issues/10371
Fixes #10371
seems that some time ago
JL_PRINTF' was removed andDLLEXPORT int jl_printf(uv_stream_t *s, const char *format, ...);` is used insteadCheers
P