Adds AbstractRNG to various methods which utilise rand. #10349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #10345. Also utilise
randexp
inrandsubseq
instead of taking log ofrand
. I had to move some methods around so thatAbstractRNG
would be defined when they were parsed.Remaining methods which call
rand
without anAbstractRNG
argument arenow done.sprand
: this is a bit complicated, as it accepts an optional functional argument for generating the values.SharedArray
andDArray
methods: I don't understand these well enough to know how they interact with the RNGmktempdir
in file.jl (windows only).peakflops
in linalg/generic.jl