Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubVectors of SubVectors are broken #8807

Closed
simonster opened this issue Oct 24, 2014 · 0 comments
Closed

SubVectors of SubVectors are broken #8807

simonster opened this issue Oct 24, 2014 · 0 comments
Assignees
@JeffBezanson
Labels
kind:bug Indicates an unexpected problem or unintended behavior kind:regression Regression in behavior compared to a previous version

Comments

@simonster
Copy link
Member 

julia> sub(sub([1:5], 1:5), 1:5)
ERROR: N not defined
 in call at subarray.jl:22
 in sub at subarray.jl:98

Presumably a regression since #8712. Encountered in StatsBase (after patching the ArrayViews issue).
@simonster simonster added kind:bug Indicates an unexpected problem or unintended behavior kind:regression Regression in behavior compared to a previous version labels Oct 24, 2014
@JeffBezanson JeffBezanson self-assigned this Oct 26, 2014
twadleigh pushed a commit to twadleigh/julia that referenced this issue Oct 29, 2014
@JeffBezanson @twadleigh
fix JuliaLang#8807, regression in constructors when evaluating field …
eeb4663 
…types

this changes `fieldtype` to accept a type as the first argument, instead
of an instance. this allows us to use it to `convert` the arguments to
`new` to the field types, instead of evaluating the field type
expressions. this is more general (e.g. in case the mapping from
field type expressions to final field types becomes more complex).
also makes `fieldtype` more similar to `fieldoffsets`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffBezanson JeffBezanson

Labels
kind:bug Indicates an unexpected problem or unintended behavior kind:regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonster @JeffBezanson