Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable backtraces for stack overflow on windows #7395

Closed
vtjnash opened this issue Jun 24, 2014 · 2 comments
Closed

enable backtraces for stack overflow on windows #7395

vtjnash opened this issue Jun 24, 2014 · 2 comments
Labels
system:windows Affects only Windows
Milestone
0.3.4

Comments

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 24, 2014

having just discovered SetThreadStackGuarantee, we could now enable backtraces for stack overflow on windows
@vtjnash vtjnash added this to the 0.4 milestone Jun 24, 2014
@vtjnash vtjnash modified the milestones: 0.3.4, 0.4 Dec 16, 2014
@tkelman
Copy link
Contributor

tkelman commented Dec 17, 2014

for @JuliaBackports, make sure to include 0b44aca, then this (ed5a8fc), then a2ff1ea, then 0050b72

vtjnash added a commit that referenced this issue Dec 21, 2014
@vtjnash @tkelman
Really fix #9366
c3f6c6e 
pass a stack-copy of ctxThread in jl_throw_in_ctx to rec_backtrace_ctx

(cherry picked from commit 0b44aca)

fix #7395, and copy just the useful parts of CONTEXT in jl_throw_in_ctx, before rec_backtrace_ctx destroys the recorded stack pointer

(cherry picked from commit ed5a8fc)

Conflicts:
	src/init.c

fix 32 bit oops from ed5a8fc
(cherry picked from commit a2ff1ea)

fix compiler warning on win32

(cherry picked from commit 0050b72)
@tkelman
Copy link
Contributor

tkelman commented Dec 21, 2014

backported in c3f6c6e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
system:windows Affects only Windows
Projects
None yet
Milestone
0.3.4
Development

No branches or pull requests
2 participants
@vtjnash @tkelman