Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisited "Make median behave on arrays as mean and var" #6648

Closed
cbecker opened this issue Apr 26, 2014 · 9 comments
Closed

Revisited "Make median behave on arrays as mean and var" #6648

cbecker opened this issue Apr 26, 2014 · 9 comments

Comments

@cbecker
Copy link
Contributor

cbecker commented Apr 26, 2014

#2266 made median work on all elements of an array, but there is still the problem that it is not possible to do median(M, 2) as a way to compute the median along a specific dimension.

@ViralBShah
Copy link
Member

Did you try mapslices? We can add the convenience definitions.

@cbecker
Copy link
Contributor Author

cbecker commented Apr 27, 2014

Thanks! I didn't know about mapslices, that's amazing. The PR above should do.

@ViralBShah
Copy link
Member

We should probably add the convenience definitions anyways. Would be great if you can submit a PR.

@cbecker
Copy link
Contributor Author

cbecker commented Apr 27, 2014

@ViralBShah I don't understand, did you see the PR right above my last comment?
It defines median( X, dims )

@ViralBShah
Copy link
Member

I don't see it. Perhaps because I an using the github android app which is not the greatest. I will take a look using a browser.

@cbecker
Copy link
Contributor Author

cbecker commented Apr 27, 2014

@ViralBShah in case it helps: #6666
It has a rather unusual PR number ;)

@ViralBShah
Copy link
Member

Thanks. Shows in the browser. Did not show in the app. Nice number!

@cbecker
Copy link
Contributor Author

cbecker commented Apr 27, 2014

@ViralBShah PR now contains tests + docs, ready to merge.

ViralBShah pushed a commit that referenced this issue Apr 28, 2014
Median along arbitrary dimensions, fixes #6648
@ViralBShah
Copy link
Member

Thanks, merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants