Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs for bytestring unclear about encodings #6585

Closed
nalimilan opened this issue Apr 19, 2014 · 1 comment
Closed

Docs for bytestring unclear about encodings #6585

nalimilan opened this issue Apr 19, 2014 · 1 comment

Comments

@nalimilan
Copy link
Member

The documentation for bytestring(Array{Uint8, 1}) do not say anything about the encoding which is assumed. Looking at the code, it seems to use ASCII if all characters are valid ASCII, and UTF-8 otherwise. Is that right?
nalimilan added a commit to nalimilan/julia that referenced this issue Apr 19, 2014
@nalimilan
clarify doc for bytestring(), contd. re-fixes JuliaLang#6585
7c9b430
@nalimilan
Copy link
Member Author

Thanks, but I find the first description still slightly confusing since encoded might mean re-encoded. As these issues are really messy, I'd prefer the wording to be completely explicit. I've made a PR: #6588

JeffBezanson added a commit that referenced this issue Apr 19, 2014
@JeffBezanson
Merge pull request #6588 from nalimilan/bytestring
850825d 
clarify doc for bytestring(), contd. re-fixes #6585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nalimilan