Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack overflow during gc_read_stack on win32 #54711

Closed
d-netto opened this issue Jun 6, 2024 · 2 comments · Fixed by #54718
Closed

Stack overflow during gc_read_stack on win32 #54711

d-netto opened this issue Jun 6, 2024 · 2 comments · Fixed by #54718
Labels
domain:ci Continuous integration kind:bug Indicates an unexpected problem or unintended behavior system:windows Affects only Windows system:32-bit Affects only 32-bit systems

Comments

@d-netto
Copy link
Member

d-netto commented Jun 6, 2024

Saw in a few places. One example here: https://buildkite.com/julialang/julia-master/builds/37111#018feb4c-a436-49ef-b2a3-63213aa05f67.
@d-netto d-netto added kind:bug Indicates an unexpected problem or unintended behavior domain:ci Continuous integration labels Jun 6, 2024
@oscardssmith oscardssmith added system:windows Affects only Windows system:32-bit Affects only 32-bit systems labels Jun 6, 2024
@gbaraldi
Copy link
Member

gbaraldi commented Jun 6, 2024

First bad commit seems to be b946b94, will try a revert.

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 6, 2024

Looks like this is an issue introduced by #36227. In short, there was a small mistake in prepend vs. append

vtjnash added a commit that referenced this issue Jun 6, 2024
@vtjnash
fix prepend StackOverflow issue
8c81bd1 
Attempt to fix #54711
Test introduced by #36227
vtjnash added a commit that referenced this issue Jun 6, 2024
@vtjnash
fix prepend StackOverflow issue
3e2dc41 
Attempt to fix #54711
Test introduced by #36227
@vtjnash vtjnash mentioned this issue Jun 6, 2024
Merged
vtjnash added a commit that referenced this issue Jun 6, 2024
@vtjnash
fix prepend StackOverflow issue
fec1e18 
Attempt to fix #54711
Test introduced by #36227
aviatesk added a commit that referenced this issue Jun 7, 2024
@vtjnash @aviatesk
fix prepend StackOverflow issue (#54718)
9477472 
Attempt to fix #54711
Test introduced by #36227

---------

Co-authored-by: Shuhei Kadowaki <[email protected]>
KristofferC pushed a commit that referenced this issue Jun 13, 2024
@vtjnash
fix prepend StackOverflow issue (#54718)
fe51261 
Attempt to fix #54711
Test introduced by #36227

---------

Co-authored-by: Shuhei Kadowaki <[email protected]>
(cherry picked from commit 9477472)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:ci Continuous integration kind:bug Indicates an unexpected problem or unintended behavior system:windows Affects only Windows system:32-bit Affects only 32-bit systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix prepend StackOverflow issue JuliaLang/julia
4 participants
@vtjnash @oscardssmith @gbaraldi @d-netto