Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpreter does not respect generated function edges/world ages #54360

Closed
Keno opened this issue May 5, 2024 · 0 comments · Fixed by #54362
Closed

Interpreter does not respect generated function edges/world ages #54360

Keno opened this issue May 5, 2024 · 0 comments · Fixed by #54362
Assignees
@Keno
Labels
compiler:interpreter

Comments

@Keno
Copy link
Member

Keno commented May 5, 2024 

$ ./julia -q --compile=min
julia> using Test

julia> include("test/compiler/contextual.jl")
Test Failed at /home/keno/julia/test/compiler/contextual.jl:118
  Expression: overdub(Ctx(), f) === 2
   Evaluated: 1 === 2

ERROR: LoadError: There was an error during testing
in expression starting at /home/keno/julia/test/compiler/contextual.jl:118
@Keno Keno self-assigned this May 5, 2024
Keno added a commit that referenced this issue May 5, 2024
@Keno
interpreter: Use world-age-partitioned cache for @generated results
3c054df 
This fixes #54360 by moving the interpreter's cache of `@generated`
results from `mi.uninferred` into `mi.cache` with a separate cache owner
to partition the cache from regular inference results. There are two
other uses of the `mi.uninferred` field:

1. As the place to store uninferred code for temporary top-level thunks
2. Is an uncompressed copy of m->source to avoid having to re-uncompress
   every time in the interpreter.

In this PR, use case 1 is changed to use the same mechanism as generated
functions. Use case 2 is changed to just uncompress the source in place in
m->source. As a result, the `uninferred` field is unused and removed.

Note that I'm planning a somewhat larger refactor of `MethodInstance` in
the immediate future, so this might be a somewhat shortlived representation,
but that change should hopefully by largely transparent to users of the
wrappers introduced here.
@Keno Keno mentioned this issue May 5, 2024
Merged
Keno added a commit that referenced this issue May 5, 2024
@Keno
interpreter: Use world-age-partitioned cache for @generated results
fae1796 
This fixes #54360 by moving the interpreter's cache of `@generated`
results from `mi.uninferred` into `mi.cache` with a separate cache owner
to partition the cache from regular inference results. There are two
other uses of the `mi.uninferred` field:

1. As the place to store uninferred code for temporary top-level thunks
2. Is an uncompressed copy of m->source to avoid having to re-uncompress
   every time in the interpreter.

In this PR, use case 1 is changed to use the same mechanism as generated
functions. Use case 2 is changed to just uncompress the source in place in
m->source. As a result, the `uninferred` field is unused and removed.

Note that I'm planning a somewhat larger refactor of `MethodInstance` in
the immediate future, so this might be a somewhat shortlived representation,
but that change should hopefully by largely transparent to users of the
wrappers introduced here.
Keno added a commit that referenced this issue May 7, 2024
@Keno
interpreter: Use world-age-partitioned cache for @generated results
a3c1309 
This fixes #54360 by moving the interpreter's cache of `@generated`
results from `mi.uninferred` into `mi.cache` with a separate cache owner
to partition the cache from regular inference results. There are two
other uses of the `mi.uninferred` field:

1. As the place to store uninferred code for temporary top-level thunks
2. Is an uncompressed copy of m->source to avoid having to re-uncompress
   every time in the interpreter.

In this PR, use case 1 is changed to use the same mechanism as generated
functions. Use case 2 is changed to just uncompress the source in place in
m->source. As a result, the `uninferred` field is unused and removed.

Note that I'm planning a somewhat larger refactor of `MethodInstance` in
the immediate future, so this might be a somewhat shortlived representation,
but that change should hopefully by largely transparent to users of the
wrappers introduced here.
Keno added a commit that referenced this issue May 7, 2024
@Keno
interpreter: Use world-age-partitioned cache for @generated results (#…
dbf0bab 
…54362)

This fixes #54360 by moving the interpreter's cache of `@generated`
results from `mi.uninferred` into `mi.cache` with a separate cache owner
to partition the cache from regular inference results. There are two
other uses of the `mi.uninferred` field:

1. As the place to store uninferred code for temporary top-level thunks
2. Is an uncompressed copy of m->source to avoid having to re-uncompress
every time in the interpreter.

In this PR, use case 1 is changed to use the same mechanism as generated
functions. Use case 2 is changed to just uncompress the source in place
in m->source. As a result, the `uninferred` field is unused and removed.

Note that I'm planning a somewhat larger refactor of `MethodInstance` in
the immediate future, so this might be a somewhat shortlived
representation, but that change should hopefully by largely transparent
to users of the wrappers introduced here.
xlxs4 pushed a commit to xlxs4/julia that referenced this issue May 9, 2024
@Keno @xlxs4
interpreter: Use world-age-partitioned cache for @generated results (J…
3de02ee 
…uliaLang#54362)

This fixes JuliaLang#54360 by moving the interpreter's cache of `@generated`
results from `mi.uninferred` into `mi.cache` with a separate cache owner
to partition the cache from regular inference results. There are two
other uses of the `mi.uninferred` field:

1. As the place to store uninferred code for temporary top-level thunks
2. Is an uncompressed copy of m->source to avoid having to re-uncompress
every time in the interpreter.

In this PR, use case 1 is changed to use the same mechanism as generated
functions. Use case 2 is changed to just uncompress the source in place
in m->source. As a result, the `uninferred` field is unused and removed.

Note that I'm planning a somewhat larger refactor of `MethodInstance` in
the immediate future, so this might be a somewhat shortlived
representation, but that change should hopefully by largely transparent
to users of the wrappers introduced here.
lazarusA pushed a commit to lazarusA/julia that referenced this issue Jul 12, 2024
@Keno @lazarusA
interpreter: Use world-age-partitioned cache for @generated results (J…
657a486 
…uliaLang#54362)

This fixes JuliaLang#54360 by moving the interpreter's cache of `@generated`
results from `mi.uninferred` into `mi.cache` with a separate cache owner
to partition the cache from regular inference results. There are two
other uses of the `mi.uninferred` field:

1. As the place to store uninferred code for temporary top-level thunks
2. Is an uncompressed copy of m->source to avoid having to re-uncompress
every time in the interpreter.

In this PR, use case 1 is changed to use the same mechanism as generated
functions. Use case 2 is changed to just uncompress the source in place
in m->source. As a result, the `uninferred` field is unused and removed.

Note that I'm planning a somewhat larger refactor of `MethodInstance` in
the immediate future, so this might be a somewhat shortlived
representation, but that change should hopefully by largely transparent
to users of the wrappers introduced here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Keno Keno

Labels
compiler:interpreter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

interpreter: Use world-age-partitioned cache for @generated results JuliaLang/julia
1 participant
@Keno