-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ifelse codegen produces invalid IR #50379
Labels
compiler:codegen
Generation of LLVM IR and native code
kind:regression
Regression in behavior compared to a previous version
Milestone
Comments
maleadt
added
kind:regression
Regression in behavior compared to a previous version
compiler:codegen
Generation of LLVM IR and native code
labels
Jul 1, 2023
topolarity
added a commit
to topolarity/julia
that referenced
this issue
Jul 12, 2023
In the presence of `attach_after` insertions, we have to be careful to extend the basic block to include everything up to the last insertion. We were accounting for "new" nodes (before the compaction point), but not "pending" nodes (after the compaction point). Fixes JuliaLang#50379.
maleadt
pushed a commit
that referenced
this issue
Jul 13, 2023
In the presence of `attach_after` insertions, we have to be careful to extend the basic block to include everything up to the last insertion. We were accounting for "new" nodes (before the compaction point), but not "pending" nodes (after the compaction point). Fixes #50379.
KristofferC
pushed a commit
that referenced
this issue
Jul 17, 2023
In the presence of `attach_after` insertions, we have to be careful to extend the basic block to include everything up to the last insertion. We were accounting for "new" nodes (before the compaction point), but not "pending" nodes (after the compaction point). Fixes #50379. (cherry picked from commit cdec4c2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compiler:codegen
Generation of LLVM IR and native code
kind:regression
Regression in behavior compared to a previous version
As seen on PkgEval.jl:
Using Julia#master with assertions enabled:
Bisected to #50312, so @topolarity I guess we're not out of the woods yet.
The text was updated successfully, but these errors were encountered: