edit() doesn't go to the line number when nano is the default editor on linux

[elehcim]

I'm running Kubuntu Linux 13.10, and I have /etc/alternatives/editor -> /bin/nano.

When using the function edit(file::String,line::Integer) at util.jl:147 the editor pops up always at line 1, regardless of the line parameter value.

[elehcim]

I tried to fix this by looking into the sources, but the problem seems that I don't have any ENV["EDITOR"] value, so that I cannot switch on the editor name to call the desired command which would be:
spawn(nano +$line $file)

Do you have any idea on why there is no EDITOR key in my environment dictionary ENV?

[timholy]

I don't think it's defined by default, but you can set it by saying export EDITOR=nano in the shell that you launch julia from.

[JeffBezanson]

We should use something like readlink to determine which editor is actually being used by /etc/alternatives/editor.

[StefanKarpinski]

This whole edit business is kind of a mess and needs an overhaul. I just side-stepped the whole thing when implementing Pkg.edit() and just used the traditional EDITOR / VISUAL variables:

julia/base/pkg/entry.jl

Lines 16 to 28 in 20b76e4

	function edit(f::Function, pkg::String, args...)
	r = Reqs.read("REQUIRE")
	reqs = Reqs.parse(r)
	avail = Read.available()
	!haskey(avail,pkg) && !haskey(reqs,pkg) && return false
	rʹ = f(r,pkg,args...)
	rʹ == r && return false
	reqsʹ = Reqs.parse(rʹ)
	reqsʹ != reqs && resolve(reqsʹ,avail)
	Reqs.write("REQUIRE",rʹ)
	info("REQUIRE updated.")
	return true
	end

.

[elehcim]

+1 for readlink. I was thinking the same.