Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plots.jl not working on Julia master -- LoadError: MethodError: no method matching sizehint!(::RecipesPipeline.DefaultsDict, ::Int64) #44686

Closed
truedichotomy opened this issue Mar 20, 2022 · 3 comments · Fixed by #44687
Closed

Plots.jl not working on Julia master -- LoadError: MethodError: no method matching sizehint!(::RecipesPipeline.DefaultsDict, ::Int64) #44686

truedichotomy opened this issue Mar 20, 2022 · 3 comments · Fixed by #44687

Comments

@truedichotomy
Copy link

Not sure if this is a Julia issue or a package issue but Plots.jl is currently broken on the Julia master. I filed an issue in Plots.jl and referencing here in case the issue lies with changes in Julia master:

JuliaPlots/Plots.jl#4144 (comment)

versioninfo:

Julia Version 1.9.0-DEV.218
Commit 1b686b2633 (2022-03-19 09:28 UTC)
Platform Info:
  OS: macOS (arm64-apple-darwin21.4.0)
  CPU: 8 × Apple M1
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, apple-m1)
  Threads: 1 on 4 virtual cores
@KristofferC
Copy link
Sponsor Member

#44659

@petvana
Copy link
Member

petvana commented Mar 20, 2022

Sorry, it was my incorrect assumption that AbstractDict should always implement sizehint!. The easy fix would be to have a fallback implementation in abstractdict.jl

# Fallback implementation
sizehint!(d::AbstractDict, size) = nothing

@simeonschaub
Copy link
Member

We already have that for AbstractSet, so I don't think that would be entirely unreasonable

@petvana petvana mentioned this issue Mar 20, 2022
Merged
vtjnash pushed a commit that referenced this issue Mar 21, 2022
@petvana
Fallback implementation of sizehint! for AbstractDict (#44687)
a6187ea 
Fixes #44686 + additional haslength check + docs that sizehint! returns the collection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fallback implementation of sizehint! for AbstractDict petvana/julia
4 participants
@KristofferC @simeonschaub @petvana @truedichotomy