Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New syntax error on 1.8+ #44239

Closed
KristofferC opened this issue Feb 18, 2022 · 0 comments · Fixed by #44246
Closed

New syntax error on 1.8+ #44239

KristofferC opened this issue Feb 18, 2022 · 0 comments · Fixed by #44246
Assignees
@JeffBezanson
Labels
regression Regression in behavior compared to a previous version
Milestone
1.8

Comments

@KristofferC
Copy link
Member

KristofferC commented Feb 18, 2022 •
edited
Loading

On 1.8:

julia> A[a = a, b...]
ERROR: syntax: invalid syntax a = a
Stacktrace:
 [1] top-level scope
   @ REPL[3]:1

Not sure if this is intended. This syntax was valid on 1.7. Affects code in the wild, for example:

https://github.com/ITensor/ITensors.jl/blob/cbbe909dcbda4cf70c8ecb7679128962cda3ebc4/src/mps/abstractmps.jl#L1419-L1421
@KristofferC KristofferC added this to the 1.8 milestone Feb 18, 2022
@JeffBezanson JeffBezanson self-assigned this Feb 18, 2022
@JeffBezanson JeffBezanson added the regression Regression in behavior compared to a previous version label Feb 18, 2022
JeffBezanson added a commit that referenced this issue Feb 18, 2022
@JeffBezanson
fix #44239, regression in keyword args in getindex
62c7141
JeffBezanson added a commit that referenced this issue Feb 18, 2022
@JeffBezanson
fix #44239, regression in keyword args in getindex
f02dac4
@JeffBezanson JeffBezanson mentioned this issue Feb 18, 2022
Merged
KristofferC pushed a commit that referenced this issue Feb 19, 2022
@JeffBezanson
fix #44239, regression in keyword args in getindex (#44246)
4061e8f
KristofferC pushed a commit that referenced this issue Feb 23, 2022
@JeffBezanson
fix #44239, regression in keyword args in getindex (#44246)
f1cb219 
(cherry picked from commit 4061e8f)
staticfloat pushed a commit to JuliaCI/julia-buildkite-testing that referenced this issue Mar 2, 2022
@JeffBezanson @staticfloat
fix JuliaLang#44239, regression in keyword args in getindex (JuliaLan…
4a0afe4 
…g#44246)
LilithHafner pushed a commit to LilithHafner/julia that referenced this issue Mar 8, 2022
@JeffBezanson @LilithHafner
fix JuliaLang#44239, regression in keyword args in getindex (JuliaLan…
32db8d2 
…g#44246)
KristofferC pushed a commit that referenced this issue Mar 19, 2022
@JeffBezanson @KristofferC
fix #44239, regression in keyword args in getindex (#44246)
3c8241c 
(cherry picked from commit 4061e8f)
KristofferC pushed a commit that referenced this issue Apr 21, 2022
@JeffBezanson @KristofferC
fix #44239, regression in keyword args in getindex (#44246)
86e06d3 
(cherry picked from commit 4061e8f)
staticfloat pushed a commit that referenced this issue Dec 23, 2022
@JeffBezanson @staticfloat
fix #44239, regression in keyword args in getindex (#44246)
a8c1cd3 
(cherry picked from commit 4061e8f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffBezanson JeffBezanson

Labels
regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
1.8
Development

Successfully merging a pull request may close this issue.

fix #44239, regression in keyword args in getindex JuliaLang/julia
2 participants
@JeffBezanson @KristofferC