-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decision on export of Base modules names #3924
Comments
Beat me too it ;) Yes, i say we stop exporting these modules, if possible. |
The common usage of the sorting and ordering APIs don't require access to these modules anymore, so yes, we should stop exporting these. I mostly didn't change things because I wasn't sure about a smooth deprecation strategy but maybe we should just not export them and let people fix their code when it breaks. |
nolta
added a commit
that referenced
this issue
Aug 6, 2013
RFC: unexport a bunch of Base modules (closes #3924)
staticfloat
pushed a commit
that referenced
this issue
Jun 18, 2024
Stdlib: Pkg URL: https://github.com/JuliaLang/Pkg.jl.git Stdlib branch: master Julia branch: master Old commit: 78bca4227 New commit: 8c996799b Julia version: 1.12.0-DEV Pkg version: 1.12.0 Bump invoked by: @DilumAluthge Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaLang/Pkg.jl@78bca42...8c99679 ``` $ git log --oneline 78bca4227..8c996799b 8c996799b Fix HistoricalStdlibVersions install to version (#3930) db8ce8919 update docs for test in REPL (#3924) 7f6eb8b8e avoid returning empty completion when aborting to not have it inline complete directories (#3917) ``` Co-authored-by: Dilum Aluthge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As pointed out by @nolta here, the exports in
Sort
are imported intoBase
withimportall
, and the majority of those are reexported byBase
.There are some unexported functions, but use of them should be rare, so it seems reasonable not to export
Sort
itself fromBase
, and anyone who needsSort
can importBase.Sort
.Base
?Obvious modules meant to be used with the module name include
Pkg
,Pkg2
, andProfile
; these should still be exported. Others?The text was updated successfully, but these errors were encountered: