Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown parser fails for tables with no first entry #38189

Closed
Ellipse0934 opened this issue Oct 27, 2020 · 1 comment · Fixed by #38395
Closed

Markdown parser fails for tables with no first entry #38189

Ellipse0934 opened this issue Oct 27, 2020 · 1 comment · Fixed by #38395

Comments

@Ellipse0934
Copy link
Contributor

julia> using Markdown

julia> md"""|   | 1 | 2 |    # fails to parse as table
            |:-:|:--|--:|
            |3  |4  |5  |"""
  | | 1 | 2 | |:-:|:–|–:| |3 |4 |5 |

julia> md"""| 0 |   |   |
            |:-:|:--|--:|
            |3  |4  |5  |"""
  0    
  – – –
  3 4 5

julia> md"""| 0 |   |   |
            |:-:|:--|--:|
            |   |4  |5  |"""
  0    
  – – –
    4 5
@simonbyrne simonbyrne changed the title Base.Markdown fails for tables with no first entry Markdown parser fails for tables with no first entry Oct 30, 2020
@p1scescom
Copy link
Contributor

p1scescom commented Nov 5, 2020

Tables which have empty first column of markdown fail. Its reason is this line.

isempty(row[1]) && return false

I sought this line's blame. But I cannot find why it fails.
Maybe it has to fail in this case, but I think this line isn't necessary.
And GitHub markdown allows empty first column.

second column
empty first column

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants