Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit on GitHub link is broken on NEWS page. #34511

Closed
ghost opened this issue Jan 25, 2020 · 4 comments
Closed

Edit on GitHub link is broken on NEWS page. #34511

ghost opened this issue Jan 25, 2020 · 4 comments
Labels
docsystem The documentation building system good first issue Indicates a good issue for first-time contributors to Julia status:help wanted Indicates that a maintainer wants help on an issue or pull request

Comments

@ghost
Copy link

ghost commented Jan 25, 2020

On NEWS page, Edit on GitHub link is broken.
It is going to https://github.com/JuliaLang/julia/blob/master/doc/src/NEWS.md but should go to https://github.com/JuliaLang/julia/blob/master/NEWS.md
@JeffBezanson JeffBezanson added the docsystem The documentation building system label Jan 27, 2020
@fredrikekre fredrikekre mentioned this issue Mar 30, 2020
Closed
@DonRichards
Copy link

Yep this is broken.
Screen Shot

@StefanKarpinski StefanKarpinski added good first issue Indicates a good issue for first-time contributors to Julia status:help wanted Indicates that a maintainer wants help on an issue or pull request labels Apr 14, 2020
@StefanKarpinski
Copy link
Sponsor Member

This should be a simple matter of fixing the link in the file.

@sgunadhya
Copy link
Contributor

I tested this on the latest master branch and it seems to be fixed.

@mrdofu
Copy link
Contributor

mrdofu commented Jun 10, 2020

Seems that the Edit on Github link matches the page it renders to the file on github, but the rendered file (https://github.com/JuliaLang/julia/blob/master/doc/src/NEWS.md) isn't checked into git.

Here are suggestions:

I'm not sure how these changes will work with the built documentation doc/_build

mrdofu added a commit to mrdofu/julia that referenced this issue Jun 29, 2020
@mrdofu
changed release notes (NEWS.md) edit link (JuliaLang#34511)
eca7dbd 
fixes JuliaLang#34511
@mrdofu mrdofu mentioned this issue Jun 29, 2020
Closed
mrdofu added a commit to mrdofu/julia that referenced this issue Jun 29, 2020
@mrdofu
changed release notes (NEWS.md) edit link
e8fc653 
fixes JuliaLang#34511
belamenso added a commit to belamenso/julia that referenced this issue Oct 27, 2020
@belamenso
fix JuliaLang#34511: fix broken 'Edit on GitHub' link
2d4760f
@belamenso belamenso mentioned this issue Oct 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docsystem The documentation building system good first issue Indicates a good issue for first-time contributors to Julia status:help wanted Indicates that a maintainer wants help on an issue or pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changed release notes (NEWS.md) edit link mrdofu/julia
5 participants
@StefanKarpinski @JeffBezanson @sgunadhya @DonRichards @mrdofu