Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A typo in i18n_data when testing DelimitedFiles. not "한민국" but "대한민국" #30486

Closed
petershintech opened this issue Dec 22, 2018 · 2 comments
Closed

A typo in i18n_data when testing DelimitedFiles. not "한민국" but "대한민국" #30486

petershintech opened this issue Dec 22, 2018 · 2 comments

Comments

@petershintech
Copy link
Contributor

While reading tests for DelimitedFiles, I found the following typo.

Line 209 and 210 of julia/stdlib/DelimitedFiles/test/runtests.jl:
"Rep. of Korea", "AHN Sung-Gi", "한민국", "안성기",
"Rep. of Korea", "SHIM Eun-Ha", "한민국", "심은하",

The official country name of Rep. of Korea Korea is:
"대한민국" not "한민국"
@StefanKarpinski
Copy link
Sponsor Member

Care to make a PR to fix it?

@petershintech petershintech mentioned this issue Jan 3, 2019
Merged
ararslan pushed a commit that referenced this issue Jan 3, 2019
@petershintech @ararslan
Fix a typo on a Korean letter. Not "한민국" but "대한민국" (#30567)
5233ec0 
Fix for #30486
@fredrikekre
Copy link
Member

#30567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@StefanKarpinski @fredrikekre @petershintech