Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subtyping regression: Union{Ref{T}, Ref{T}} and Ref{T} behave differently #26180

Closed
ulysses4ever opened this issue Feb 23, 2018 · 0 comments · Fixed by #26691
Closed

subtyping regression: Union{Ref{T}, Ref{T}} and Ref{T} behave differently #26180

ulysses4ever opened this issue Feb 23, 2018 · 0 comments · Fixed by #26691
Assignees
@JeffBezanson
Labels
domain:types and dispatch Types, subtyping and method dispatch kind:regression Regression in behavior compared to a previous version

Comments

@ulysses4ever
Copy link
Contributor

In 0.6.2

julia> Ref{Union{Ref{Int64}, Ref{Number}}} <: Ref{Ref{T}} where T
false

julia> Ref{Union{Ref{Int64}, Ref{Number}}} <: Ref{Union{Ref{T}, Ref{T}}} where T
false

which is fine, but the same checks in current master give this:

   _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: https://docs.julialang.org
   _ _   _| |_  __ _   |  Type "?help" for help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 0.7.0-DEV.4069 (2018-02-23 09:01 UTC)
 _/ |\__'_|_|_|\__'_|  |  Commit f4d82b2 (0 days old master)
|__/                   |  x86_64-linux-gnu

julia> Ref{Union{Ref{Int64}, Ref{Number}}} <: Ref{Ref{T}} where T
false

julia> Ref{Union{Ref{Int64}, Ref{Number}}} <: Ref{Union{Ref{T}, Ref{T}}} where T
true
@mbauman mbauman added the domain:types and dispatch Types, subtyping and method dispatch label Feb 23, 2018
@Keno Keno added the kind:regression Regression in behavior compared to a previous version label Feb 24, 2018
@JeffBezanson JeffBezanson self-assigned this Apr 3, 2018
JeffBezanson added a commit that referenced this issue Apr 3, 2018
@JeffBezanson
accumulate environment in forall loop in subtyping
75ebf28 
fix #26654, fix #26180, fix #25240
@JeffBezanson JeffBezanson mentioned this issue Apr 3, 2018
Merged
JeffBezanson added a commit that referenced this issue Apr 4, 2018
@JeffBezanson
accumulate environment in forall loop in subtyping (#26691)
e81dd5e 
fix #26654, fix #26180, fix #25240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffBezanson JeffBezanson

Labels
domain:types and dispatch Types, subtyping and method dispatch kind:regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

accumulate environment in forall loop in subtyping JuliaLang/julia
4 participants
@mbauman @JeffBezanson @Keno @ulysses4ever