Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcat of range and matrix causes stack overflow #25770

Closed
iamed2 opened this issue Jan 27, 2018 · 2 comments
Closed

vcat of range and matrix causes stack overflow #25770

iamed2 opened this issue Jan 27, 2018 · 2 comments
Labels
domain:arrays [a, r, r, a, y, s] kind:bug Indicates an unexpected problem or unintended behavior

Comments

@iamed2
Copy link
Contributor

iamed2 commented Jan 27, 2018 

julia> vcat(1:8, fill(1, (4, 1)))
ERROR: StackOverflowError:
Stacktrace:
 [1] Type at ./boot.jl:364 [inlined]
 [2] Type at ./boot.jl:378 [inlined]
 [3] fill at ./array.jl:340 [inlined]
 [4] vcat(::UnitRange{Int64}, ::Array{Int64,2}) at /Users/ericdavies/repos/juliamaster/usr/share/julia/site/v0.7/LinearAlgebra/src/uniformscaling.jl:297 (repeats 47636 times)
 [5] top-level scope

Tried it on 0.6.2 and 0.7.0-DEV.3563 with the same results.

Originally found by @spurll
@ararslan ararslan added kind:bug Indicates an unexpected problem or unintended behavior domain:arrays [a, r, r, a, y, s] labels Jan 27, 2018
@iblislin
Copy link
Member

iblislin commented Jan 27, 2018 •
edited
Loading

Found this got stack overflow, also

vcat(1:8, reshape([1, 1, 1, 1], 4, 1))

stevengj added a commit to stevengj/julia that referenced this issue Jan 27, 2018
@stevengj
add AbstractVecOrMat fallback for vcat (fixes JuliaLang#25770)
68f7d22
@stevengj stevengj mentioned this issue Jan 27, 2018
Merged
@stevengj
Copy link
Member

Just submitted a fix.

JeffBezanson pushed a commit that referenced this issue Jan 28, 2018
@stevengj @JeffBezanson
add AbstractVecOrMat fallback for vcat (fixes #25770) (#25777)
3a27e01
ararslan pushed a commit that referenced this issue Apr 26, 2018
@stevengj @ararslan
add AbstractVecOrMat fallback for vcat (fixes #25770) (#25777)
7e9a1b8 
Ref #25777
(cherry picked from commit 3a27e01)
ararslan pushed a commit that referenced this issue Apr 26, 2018
@stevengj @ararslan
add AbstractVecOrMat fallback for vcat (fixes #25770) (#25777)
c4109dc 
Ref #25777
(cherry picked from commit 3a27e01)
ararslan pushed a commit that referenced this issue May 11, 2018
@stevengj @ararslan
add AbstractVecOrMat fallback for vcat (fixes #25770) (#25777)
129f685 
Ref #25777
(cherry picked from commit 3a27e01)
ararslan pushed a commit that referenced this issue May 27, 2018
@stevengj @ararslan
add AbstractVecOrMat fallback for vcat (fixes #25770) (#25777)
72c3e62 
Ref #25777
(cherry picked from commit 3a27e01)
ararslan added a commit that referenced this issue Jun 20, 2018
@ararslan
Revert "add AbstractVecOrMat fallback for vcat (fixes #25770) (#25777)"
24c3674 
This reverts commit 3a27e01.
As noted in #27652, this change is breaking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:arrays [a, r, r, a, y, s] kind:bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iblislin @stevengj @iamed2 @ararslan