Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string interpolation identifier character blacklist #25231

Closed
StefanKarpinski opened this issue Dec 21, 2017 · 0 comments · Fixed by #25234
Closed

string interpolation identifier character blacklist #25231

StefanKarpinski opened this issue Dec 21, 2017 · 0 comments · Fixed by #25234
Labels
domain:strings "Strings!"
Milestone

Comments

@StefanKarpinski
Copy link
Sponsor Member

From #25178:

The minimal change for 1.0 is to implement an identifier blacklist and only allow bare name interpolation when the identifier is not followed by something not on the blacklist (i.e. followed by either a blacklisted character or the end of the string). I kind of like the idea of the $ prefix for $-interpolating strings, but I'm not that against just continuing with $ unprefixed.

@stevengj suggested as an initial blacklist:

Operator characters, #, whitespace, and most punctuation

This should be done for 1.0 but does not need to be done right away since this would affect very little code in the wild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:strings "Strings!"
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant