deprecated_moved not working properly inside modules

[stevengj]

(From JuliaMath/FFTW.jl#47, cc @EthanAnderes and @ararslan.) The @deprecate_moved macro in #22763 was supposed to allow the FFTW.jl module to replace the deprecated Base.FFTW module without hitting warnings. And indeed it works fine in Main:

julia> using FFTW   # loads FFTW.jl and replaces Base.FFTW

julia> FFTW.PATIENT
0x00000020

but inside a module it is not working:

ulia> module Foo
          using FFTW
          const foo = FFTW.PATIENT
      end
WARNING: both FFTW and Base export "FFTW"; uses of it in module Foo must be qualified
ERROR: UndefVarError: FFTW not defined

So, there is some aspect of symbol resolution that was missed in #22763.

cc @JeffBezanson

[stevengj]

The problem seems to be that the Base.DFT.FFTW itself is not marked as deprecated:

julia> Base.isdeprecated(Base.DFT, :fft)
true

julia> Base.isdeprecated(Base.DFT, :FFTW)
false