deprecate bits to bitstring #24281
Merged
deprecate bits to bitstring #24281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sacha0
added
kind:deprecation
Sacha0
force-pushed
the
bitstring
branch
2 times, most recently
from
b1444a4
to
33c2ba6
Compare
Sacha0
force-pushed
the
bitstring
branch
2 times, most recently
from
49b7a84
to
2eaa6c3
Compare
fredrikekre
approved these changes
Oct 23, 2017
NEWS.md
Outdated
| @@ -556,8 +556,9 @@ Deprecated or removed | |||
| `ReinterpretArray`. The three argument form of `reinterpret` that implicitly reshapes | |||
| has been deprecated ([#23750]). | |||
|
|
|||
| * `num2hex` and `hex2num` have been deprecated in favor of `reinterpret` combined with `parse`/`hex` | |||
| ([#22088]) | |||
| * `bits` has been deprecated in favor of `bitstring` ([#WHATAREBIRDS]). | |||
base/deprecated.jl
Outdated
| @@ -1913,6 +1913,9 @@ end | |||
| @deprecate float(x::AbstractString) parse(Float64, x) | |||
| @deprecate float(a::AbstractArray{<:AbstractString}) parse.(Float64, a) | |||
|
|
|||
| # deprecate bits to bitstring | |||
| @deprecate bits(x) bitstring(x) | |||
There was a problem hiding this comment.
I suppose this could be @deprecate bits bitstring?
There was a problem hiding this comment.
Good call! Simplified. Thanks! :)
|
Thanks all! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request deprecates
bitstobitstring, addressing #24263. Best!