-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename bits
to bitstring
?
#24263
Milestone
Comments
This was referenced Oct 23, 2017
Closed by #24281. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Mentioned here, the
bits
function, as named, should return a vector of Bools, but instead returns a string of'0'
and'1'
characters that are a convenient representation of the bits of the item in question. Rather than change the functionality to something less convenient, I propose renaming the function tobitstring
which indicates that it returns a string representing the bits.The text was updated successfully, but these errors were encountered: