Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowering bug using global annotation inside a let block using where syntax #22122

Closed
musm opened this issue May 29, 2017 · 3 comments · Fixed by #22166
Closed

lowering bug using global annotation inside a let block using where syntax #22122

musm opened this issue May 29, 2017 · 3 comments · Fixed by #22166
Assignees
Labels
bug Indicates an unexpected problem or unintended behavior compiler:lowering Syntax lowering (compiler front end, 2nd stage)

Comments

@musm
Copy link
Contributor

musm commented May 29, 2017

the following does not work

julia> let
       global @inline function foo(x::T) where {T}
       T
       end
       end

but the following does work

julia> let
       global @inline function foo{T}(x::T)
       T
       end
       end
@yuyichao yuyichao added the compiler:lowering Syntax lowering (compiler front end, 2nd stage) label May 29, 2017
@yuyichao
Copy link
Contributor

I assume you mean that the first version doesn't actually make it a global.

@musm
Copy link
Contributor Author

musm commented May 29, 2017

yes

@musm musm changed the title parser bug with global annotation within let block and where syntax lowering bug using global annotation inside a let block using where syntax May 29, 2017
@TotalVerb
Copy link
Contributor

TotalVerb commented May 30, 2017

duplicate (sort of) of #21581, where I listed some code sites that need to be updated for where and ::... it's going to be quite a bit of work.

@JeffBezanson JeffBezanson self-assigned this May 31, 2017
@JeffBezanson JeffBezanson added the bug Indicates an unexpected problem or unintended behavior label May 31, 2017
JeffBezanson added a commit that referenced this issue May 31, 2017
JeffBezanson added a commit that referenced this issue Jun 1, 2017
JeffBezanson added a commit that referenced this issue Jun 1, 2017
JeffBezanson added a commit that referenced this issue Jun 1, 2017
tkelman pushed a commit that referenced this issue Jun 3, 2017
fixes #22135, fixes #22122, fixes #22026, fixes #21581, fixes #16096, fixes #19351

(cherry picked from commit 60675d2)
ref #22166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior compiler:lowering Syntax lowering (compiler front end, 2nd stage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants