Day of week (Monday, Tuesday, ...) and Months might be Enum

[femtotrader]

Following #19208

Day of week (Monday, Tuesday, ...) might be an Enum instead of an Int

See

julia/base/dates/query.jl

Line 30 in 30bf89f

const Monday,Tuesday,Wednesday,Thursday,Friday,Saturday,Sunday = 1,2,3,4,5,6,7

So

const Monday,Tuesday,Wednesday,Thursday,Friday,Saturday,Sunday = 1,2,3,4,5,6,7
const Mon,Tue,Wed,Thu,Fri,Sat,Sun = 1,2,3,4,5,6,7

could be replaced by

@enum(DayOfWeek, 
    Monday = 1,
    Tuesday,
    Wednesday,
    Thursday,
    Friday,
    Saturday,
    Sunday
)
Mon, Tue, Wed, Thu, Fri, Sat, Sun = Monday, Tuesday, Wednesday, Thursday, Friday, Saturday, Sunday

[simonbyrne]

Months could also be an enum, though this might be a bit more of a breaking change.

[femtotrader]

I'm also for Months as Enum (see #19221 )

But this should probably be part of an other PR.

My opinion is also that we should also take care of performance benchmarking.

Is there any website which display such graph
like http:https://pandas.pydata.org/pandas-docs/vbench/vb_index_object.html ?

It will help to see performance regression.

PS: An other example of benchmark https://pv.github.io/numpy-bench/

[quinnj]

I'll drop a breadcrumb here of some past benchmarks I did for Dates code. It obviously needs restructuring in order to get into BaseBenchmarks.jl, but might be a useful starting point if someone is up for it.

[quinnj]

Link to old Dates benchmarks: https://github.com/quinnj/Dates.jl/blob/master/perf/perf.jl

[femtotrader]

So there is no website to display historical values after each commit ?

[StefanKarpinski]

So there is no website to display historical values after each commit ?

💯 this is what I've wanted for a rather long time.

[simonbyrne]

See JuliaCI/BaseBenchmarks.jl#39