Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indmax on subarrays returns Tuple instead of Integer #13888

Closed
baggepinnen opened this issue Nov 6, 2015 · 4 comments
Closed

indmax on subarrays returns Tuple instead of Integer #13888

baggepinnen opened this issue Nov 6, 2015 · 4 comments
Assignees

Comments

@baggepinnen
Copy link
Contributor

julia> indmax(sub(randn(10,10),1,:))
(1:10,2)

help?> indmax
search: indmax findmax invdigamma

indmax(itr) -> Integer

Returns the index of the maximum element in a collection.

julia> versioninfo()
Julia Version 0.4.1-pre+16
Commit 2cdef5d (2015-10-24 06:33 UTC)
Platform Info:
System: Linux (x86_64-redhat-linux)
CPU: Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
WORD_SIZE: 64
BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Haswell)
LAPACK: libopenblas64_
LIBM: libopenlibm
LLVM: libLLVM-3.3

@andreasnoack
Copy link
Member

This broke in 7bcc947. @timholy, any idea about how to fix this?

@timholy
Copy link
Sponsor Member

timholy commented Nov 6, 2015

Yeah...fix my buggy implementation of iterstate for CartesianRange iteration. Gotta run now, though.

@timholy timholy self-assigned this Nov 6, 2015
@tkelman
Copy link
Contributor

tkelman commented Nov 7, 2015

if this breaks any user code, should I revert #13235? 0.4.1 needs to go out imminently.

@timholy
Copy link
Sponsor Member

timholy commented Nov 7, 2015

No, because it fixes so many more breakages than it causes. Fix coming momentarily.

timholy added a commit that referenced this issue Nov 7, 2015
@timholy timholy closed this as completed in db1ab4a Nov 7, 2015
timholy added a commit that referenced this issue Nov 7, 2015
Fix [ind,find][min,max] for LinearFast AbstractArrays (fixes #13888)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants