Skip to content

Commit

Permalink
[REPL] Fix a REPL test failure by removing an erroneous space in test (
Browse files Browse the repository at this point in the history
…#44972)

* [REPL] remove erroneous space in test
  Introduced by #33805 (74f2de1).
* Revert "Temporarily move the `REPL` test suite to node 1, to buy us time until we fix the underlying bugs (#44961)"
  This reverts commit 322fd70.
  • Loading branch information
vtjnash committed Apr 14, 2022
1 parent 190565c commit fbec395
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
2 changes: 1 addition & 1 deletion stdlib/REPL/test/repl.jl
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ fake_repl(options = REPL.Options(confirm_exit=false,hascolor=true)) do stdin_wri
write(stdin_write, ";")
readuntil(stdout_read, "shell> ")
Base.print_shell_escaped(stdin_write, Base.julia_cmd().exec..., special=Base.shell_special)
write(stdin_write, """ -e "println(\\"HI\\")\" """)
write(stdin_write, """ -e "println(\\"HI\\")\"""")
readuntil(stdout_read, ")\"")
proc_stdout_read, proc_stdout = redirect_stdout()
get_stdout = @async read(proc_stdout_read, String)
Expand Down
5 changes: 0 additions & 5 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,6 @@ move_to_node1("Distributed")
# Ensure things like consuming all kernel pipe memory doesn't interfere with other tests
move_to_node1("stress")

# TODO: remove `REPL` from the "move to node 1" tests.
# We first need to fix the underlying bugs that are causing the `REPL` tests to frequently
# fail on the `test x86_64-apple-darwin` tester on Buildkite.
move_to_node1("REPL")

# In a constrained memory environment, run the "distributed" test after all other tests
# since it starts a lot of workers and can easily exceed the maximum memory
limited_worker_rss && move_to_node1("Distributed")
Expand Down

0 comments on commit fbec395

Please sign in to comment.