Skip to content

Commit

Permalink
Fix show test when Sockets are loaded in main. (#30119)
Browse files Browse the repository at this point in the history
  • Loading branch information
fredrikekre committed Nov 23, 2018
1 parent bc34b99 commit f4c7779
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion stdlib/Sockets/test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ end
@test inet.port == 1024
io = IOBuffer()
show(io, inet)
@test String(take!(io)) == "Sockets.InetAddr{Sockets.IPv4}(ip\"127.0.0.1\", 1024)"
str = "Sockets.InetAddr{$(isdefined(Main, :IPv4) ? "" : "Sockets.")IPv4}(ip\"127.0.0.1\", 1024)"
@test String(take!(io)) == str
end
@testset "InetAddr invalid port" begin
@test_throws InexactError Sockets.InetAddr(IPv4(127,0,0,1), -1)
Expand Down

4 comments on commit f4c7779

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

Please sign in to comment.