Skip to content

Commit

Permalink
Add timing to precompile trace compile (#54962)
Browse files Browse the repository at this point in the history 
I think this tool is there mainly to see what's taking so long, so
timing information is helpful.
  • Loading branch information
@IanButterworth
IanButterworth committed Jul 1, 2024
1 parent 1fdc6a6 commit f2558c4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion base/loading.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2858,7 +2858,7 @@ function create_expr_cache(pkg::PkgId, input::String, output::String, output_o::
opts = `-O0 --output-ji $(output) --output-incremental=yes`
end

trace = isassigned(PRECOMPILE_TRACE_COMPILE) ? `--trace-compile=$(PRECOMPILE_TRACE_COMPILE[])` : ``
trace = isassigned(PRECOMPILE_TRACE_COMPILE) ? `--trace-compile=$(PRECOMPILE_TRACE_COMPILE[]) --trace-compile-timing` : ``
io = open(pipeline(addenv(`$(julia_cmd(;cpu_target)::Cmd)
$(flags)
$(opts)
Expand Down

2 comments on commit f2558c4

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Please sign in to comment.