Skip to content

Commit

Permalink
fix typejoin docstring (#46018)
Browse files Browse the repository at this point in the history 
Co-authored-by: Shuhei Kadowaki <[email protected]>
  • Loading branch information
@t-bltg @aviatesk
t-bltg and aviatesk authored Jul 18, 2022
1 parent 94e4082 commit e1739aa
Showing 1 changed file with 12 additions and 3 deletions.
15 changes: 12 additions & 3 deletions base/promotion.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,19 @@
## type join (closest common ancestor, or least upper bound) ##

"""
typejoin(T, S)
typejoin(T, S, ...)
Return the closest common ancestor of `T` and `S`, i.e. the narrowest type from which
they both inherit.
Return the closest common ancestor of types `T` and `S`, i.e. the narrowest type from which
they both inherit. Recurses on additional varargs.
# Examples
```jldoctest
julia> typejoin(Int, Float64)
Real
julia> typejoin(Int, Float64, ComplexF32)
Number
```
"""
typejoin() = Bottom
typejoin(@nospecialize(t)) = t
Expand Down

9 comments on commit e1739aa

@maleadt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing some PkgEval development, sorry for the noise:

@nanosoldier runtests(["Example"])

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong when running your job:

NanosoldierError: failed to run tests: TaskFailedException

    nested task error: IOError: could not spawn `s3cmd put --quiet /tmp/jl_W5w841/Example.tar.zst s3:https://julialang-reports/nanosoldier/pkgeval/rr/Example-1658144377.tar.zst`: no such file or directory (ENOENT)
    Stacktrace:
     [1] _spawn_primitive
       @ ./process.jl:100
     [2] #690
       @ ./process.jl:113 [inlined]
     [3] setup_stdios
       @ ./process.jl:197
     [4] _spawn
       @ ./process.jl:112 [inlined]
     [5] #run#701
       @ ./process.jl:445
     [6] run
       @ ./process.jl:444 [inlined]
     [7] #run_sandboxed_test#58
       @ /storage/pkgeval/dev/PkgEval/src/run.jl:441
     [8] macro expansion
       @ /storage/pkgeval/dev/PkgEval/src/run.jl:715 [inlined]
     [9] #63
       @ ./task.jl:423

Logs and partial data can be found here
cc @maleadt

@maleadt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runtests(["Example"])

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - no issues were detected. A full report can be found here.

@maleadt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runtests(ALL)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong when running your job:

NanosoldierError: failed to run tests: TaskFailedException

    nested task error: AssertionError: isfile(trace_file)
    Stacktrace:
     [1] #run_sandboxed_test#58
       @ /storage/pkgeval/dev/PkgEval/src/run.jl:435
     [2] macro expansion
       @ /storage/pkgeval/dev/PkgEval/src/run.jl:709 [inlined]
     [3] #63
       @ ./task.jl:423

Logs and partial data can be found here
cc @maleadt

@maleadt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runtests(ALL)

@maleadt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully the final try:

@nanosoldier runtests(ALL)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible issues were detected. A full report can be found here.

Please sign in to comment.