Fix element type of -Symmetric(A) for e.g. Bool or JuMP.VariableRef, f…

…ixes #32374 (#32375)
JuliaLang · Jun 26, 2019 · d958419 · d958419
1 parent 7bec296
commit d958419
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/stdlib/LinearAlgebra/src/symmetric.jl b/stdlib/LinearAlgebra/src/symmetric.jl
@@ -414,8 +414,8 @@ function triu(A::Symmetric, k::Integer=0)
  end
 end
 
-(-)(A::Symmetric{Tv,S}) where {Tv,S} = Symmetric{Tv,S}(-A.data, A.uplo)
-(-)(A::Hermitian{Tv,S}) where {Tv,S} = Hermitian{Tv,S}(-A.data, A.uplo)
+(-)(A::Symmetric) = Symmetric(-A.data, sym_uplo(A.uplo))
+(-)(A::Hermitian) = Hermitian(-A.data, sym_uplo(A.uplo))
 
 ## Addition/subtraction
 for f in (:+, :-)

diff --git a/stdlib/LinearAlgebra/test/symmetric.jl b/stdlib/LinearAlgebra/test/symmetric.jl
@@ -88,6 +88,8 @@ end
  @testset "Unary minus for Symmetric/Hermitian matrices" begin
  @test (-Symmetric(asym))::typeof(Symmetric(asym)) == -asym
  @test (-Hermitian(aherm))::typeof(Hermitian(aherm)) == -aherm
+ @test (-Symmetric([true true; false false]))::Symmetric{Int,Matrix{Int}} == [-1 -1; -1 0]
+ @test (-Hermitian([true false; true false]))::Hermitian{Int,Matrix{Int}} == [-1 0; 0 0]
  end
 
  @testset "Addition and subtraction for Symmetric/Hermitian matrices" begin