Skip to content

Commit

Permalink
Partly revert "Reduce consequences of method invalidation for Dict an…
Browse files Browse the repository at this point in the history 
…d Set" (#35762)

This partly reverts commit 1da1b8d.
  • Loading branch information
@JeffBezanson
JeffBezanson committed May 6, 2020
1 parent 99dbd2d commit c3d6a46
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions base/dict.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -378,10 +378,6 @@ end

function setindex!(h::Dict{K,V}, v0, key::K) where V where K
v = convert(V, v0)
setindex!(h, v, key)
end

function setindex!(h::Dict{K,V}, v::V, key::K) where V where K
index = ht_keyindex2!(h, key)

if index > 0
Expand Down

2 comments on commit c3d6a46

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

Please sign in to comment.