Fix #11747 by defining showarray instead of show for FactorComponent

JuliaLang · Jun 18, 2015 · a23caa0 · a23caa0 · tkelman · Jun 18, 2015
1 parent 6b5b7d8
commit a23caa0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/base/sparse/cholmod.jl b/base/sparse/cholmod.jl
@@ -2,7 +2,7 @@
 
 module CHOLMOD
 
-import Base: (*), convert, copy, eltype, getindex, show, size,
+import Base: (*), convert, copy, eltype, getindex, show, showarray, size,
  linearindexing, LinearFast, LinearSlow
 
 import Base.LinAlg: (\), A_mul_Bc, A_mul_Bt, Ac_ldiv_B, Ac_mul_B, At_ldiv_B, At_mul_B,
@@ -973,7 +973,8 @@ function show(io::IO, F::Factor)
  showfactor(io, F)
 end
 
-function show(io::IO, FC::FactorComponent)
+# FactorComponent is a subtype of AbstractArray and we therefore define showarray instead of show
+function showarray(io::IO, FC::FactorComponent; kargs...)
  println(io, typeof(FC))
  showfactor(io, Factor(FC))
 end
@@ -1011,7 +1012,6 @@ function size(F::Factor, i::Integer)
  return 1
 end
 
-
 linearindexing(::Dense) = LinearFast()
 
 size(FC::FactorComponent, i::Integer) = size(FC.F, i)

diff --git a/test/sparsedir/cholmod.jl b/test/sparsedir/cholmod.jl
@@ -588,5 +588,8 @@ Dp = spdiagm(dp)
 @test_throws CHOLMOD.CHOLMODException Fs[:DUPt]
 @test_throws CHOLMOD.CHOLMODException Fs[:PLD]
 
-# Issue 11745
+# Issue 11745 - row and column pointers were not sorted in sparse(Factor)
 sparse(cholfact(sparse(Float64[ 10 1 1 1; 1 10 0 0; 1 0 10 0; 1 0 0 10]))); gc()
+
+# Issue 11747 - Wrong show method defined for FactorComponent
+Base.writemime(IOBuffer(), MIME"text/plain"(), cholfact(sparse(Float64[ 10 1 1 1; 1 10 0 0; 1 0 10 0; 1 0 0 10]))[:L])