You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
I think you spell Stefan's name incorrectly (so he didn't get pinged)...
Please also don't mention people in the commit message since the notification will be sent out everytime the commit got rebased by anyone.
8ce9f3f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you spell Stefan's name incorrectly (so he didn't get pinged)...
Please also don't mention people in the commit message since the notification will be sent out everytime the commit got rebased by anyone.
8ce9f3f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally bad practice but doesn't matter in this case since I get notified about everything on the repo.