Skip to content

Commit

Permalink
Revert "Reinstate load-time Pkg.precompile" (#51675)
Browse files Browse the repository at this point in the history
  • Loading branch information
@vchuravy
vchuravy committed Oct 12, 2023
1 parent e949236 commit 8a847d5
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions base/loading.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2004,14 +2004,7 @@ function _require(pkg::PkgId, env=nothing)

if JLOptions().use_compiled_modules == 1
if !generating_output(#=incremental=#false)
if !pkg_precompile_attempted && isinteractive()
if !isassigned(PKG_PRECOMPILE_HOOK)
# Note: Prevent load-time Pkg.precompile via `Base.PKG_PRECOMPILE_HOOK[]=Returns(nothing)`
pkgid = PkgId(UUID("44cfe95a-1eb2-52ea-b672-e2afdf69b78f"), "Pkg")
if locate_package(pkgid) !== nothing # Only try load Pkg if we can find it
require(pkgid)
end
end
if !pkg_precompile_attempted && isinteractive() && isassigned(PKG_PRECOMPILE_HOOK)
pkg_precompile_attempted = true
unlock(require_lock)
try
Expand Down

4 comments on commit 8a847d5

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Please sign in to comment.