Merge pull request #22838 from JuliaLang/rf/fix-ndigits-0

Base.ndigits0z(0, b) must return 0 (fix #22837)
JuliaLang · Jul 18, 2017 · 88435c0 · 88435c0
2 parents f77d4cf + 33ffc86
commit 88435c0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/base/intfuncs.jl b/base/intfuncs.jl
@@ -444,6 +444,7 @@ ndigits0znb(x::Bool, b::Integer) = x % Int
 # TODO: allow b::Integer
 function ndigits0zpb(x::Base.BitUnsigned, b::Int)
  # precondition: b > 1
+ x == 0 && return 0
  b < 0 && return ndigits0znb(signed(x), b)
  b == 2 && return sizeof(x)<<3 - leading_zeros(x)
  b == 8 && return (sizeof(x)<<3 - leading_zeros(x) + 2) ÷ 3

diff --git a/test/intfuncs.jl b/test/intfuncs.jl
@@ -214,3 +214,8 @@ end
 
 # issue #15911
 @inferred string(1)
+
+# issue #22837
+for b in [-100:-2; 2:100;]
+ @test Base.ndigits0z(0, b) == 0
+end