Fix isdone for empty product iterators, fixes #43921 (#43947)

* Fix the issue #43921 * add a test Co-authored-by: Kristoffer <[email protected]> (cherry picked from commit b8a77da)
JuliaLang · Dec 21, 2022 · 84cb211 · 84cb211
1 parent d156ef1
commit 84cb211
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/base/iterators.jl b/base/iterators.jl
@@ -993,6 +993,7 @@ iterate(::ProductIterator{Tuple{}}, state) = nothing
  done1 === true || return done1 # false or missing
  return _pisdone(tail(iters), tail(states)) # check tail
 end
+@inline isdone(::ProductIterator{Tuple{}}, states) = true
 @inline isdone(P::ProductIterator, states) = _pisdone(P.iterators, states)
 
 @inline _piterate() = ()

diff --git a/test/iterators.jl b/test/iterators.jl
@@ -859,3 +859,11 @@ end
  @test cumprod(x + 1 for x in 1:3) == [2, 6, 24]
  @test accumulate(+, (x^2 for x in 1:3); init=100) == [101, 105, 114]
 end
+
+@testset "empty product iterators" begin
+ v = nothing
+ for (z,) in zip(Iterators.product())
+ v = z
+ end
+ @test v == ()
+end