Skip to content

Commit

Permalink
Some updates to CONTRIBUTING.md
Browse files Browse the repository at this point in the history
  • Loading branch information
Viral B. Shah committed Dec 8, 2012
1 parent 1ec4d99 commit 7b5568d
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ Hi! Thanks for checking out Julia. If you have questions or problems, the [Julia

The Julia team uses [GitHub issues](https://github.com/JuliaLang/julia/issues) to track and discuss problems, feature requests, and pull requests.

You can make pull requests for incomplete features to get code review, in which case we have a convention of prefixing the pull request title with "RFC:" to indicate that the work is incomplete so it doesn't accidentally get merged into the master branch before it's ready.
You can make pull requests for incomplete features to get code review. The convention is to prefix the pull request title with "WIP:" or "RFC:" as appropriate to indicate that the work is incomplete, so that it is not accidentally merged.

Before submitting, make sure that all tests pass by running `make testall`. Even better, add your own tests for your change or feature to the test files in `test/`. If your contribution includes changes to Makefiles or external dependencies, make sure you can build Julia from a clean tree using `git clean -fdx` or equivalent (be careful – this command will delete any files lying around that aren't checked into git).
Before submitting, make sure that all tests pass by running `make testall`. Add your own tests for the new functionality in `test/`. If your contribution includes changes to Makefiles or external dependencies, make sure you can build Julia from a clean tree using `git clean -fdx` or equivalent (be careful – this command will delete any files lying around that aren't checked into git). Make sure that [Travis](http:https://www.travis-ci.org) greenlights the pull request with a `Good to merge` message.

*By contributing code to Julia, you are agreeing to release it under the [MIT License](https://github.com/JuliaLang/julia/tree/master/LICENSE.md).*

Expand All @@ -29,9 +29,14 @@ While getting familiar with Julia, remember to check out [the docs](http:https://docs.
## Resources

* Julia
- [Julia](http:https://julialang.org)
- [Julia Manual and Library Guide](http:https://docs.julialang.org/en/latest/)
- [Julia dev list](https://groups.google.com/forum/?fromgroups#!forum/julia-dev)
- **Homepage:** <http:https://julialang.org>
- **Mailing lists:** <http:https://julialang.org/mailing_lists>
- **IRC:** <http:https://webchat.freenode.net/?channels=julia>
- **Source code:** <https://github.com/JuliaLang/julia>
- **Git clone URL:** <git:https://github.com/JuliaLang/julia.git>
- **Documentation:** <http:https://julialang.org/manual/>
* Design of Julia
- [Julia: A Fast Dynamic Language for Technical Computing](http:https://julialang.org/images/julia-dynamic-2012-tr.pdf)
* Working with Types
- [Some Type Patterns](https://github.com/JuliaLang/julia/wiki/Code-Patterns)
- [The Type Hierarchy](https://github.com/JuliaLang/julia/wiki/Types-Hierarchy)
Expand Down

0 comments on commit 7b5568d

Please sign in to comment.