Skip to content

Commit

Permalink
remove SinkingPass from pass pipeline
Browse files Browse the repository at this point in the history
SinkingPass is not used by Clang and seems to be only used
as part of the AMDGPU pipeline (after the CFGStructurizer).

I have seen examples where it creates substantial worse code,
especially for the NVPTX, where it clusters loads and moves arithmetic
operations far away, causing a much higher register usage.
  • Loading branch information
vchuravy committed Oct 25, 2019
1 parent f806717 commit 7592a2e
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/jitlayers.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,6 @@ void addOptimizationPasses(legacy::PassManagerBase *PM, int opt_level,

// Run instcombine after redundancy elimination to exploit opportunities
// opened up by them.
PM->add(createSinkingPass()); ////////////// ****
#if JL_LLVM_VERSION < 70000
// This pass is a subset of InstructionCombiningPass in LLVM 7
// and therefore not required.
Expand Down

0 comments on commit 7592a2e

Please sign in to comment.