Skip to content

Commit

Permalink
use strict precompilation to catch stdlib ext failures
Browse files Browse the repository at this point in the history
Revert "use strict precompilation to catch stdlib ext failures"

This reverts commit c3a02fd.

precompilepkgs: report direct dep ext errors
  • Loading branch information
IanButterworth committed Jun 9, 2024
1 parent 77c28ab commit 63a10da
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions base/precompilation.jl
Original file line number Diff line number Diff line change
Expand Up @@ -385,10 +385,6 @@ function precompilepkgs(pkgs::Vector{String}=String[];
hascolor = get(io, :color, false)::Bool
color_string(cstr::String, col::Union{Int64, Symbol}) = _color_string(cstr, col, hascolor)

direct_deps = [
Base.PkgId(uuid, name)
for (name, uuid) in env.project_deps if !Base.in_sysimage(Base.PkgId(uuid, name))
]
stale_cache = Dict{StaleCacheKey, Bool}()
exts = Dict{Base.PkgId, String}() # ext -> parent
# make a flat map of each dep and its direct deps
Expand Down Expand Up @@ -428,6 +424,14 @@ function precompilepkgs(pkgs::Vector{String}=String[];
end
end

direct_deps = [
Base.PkgId(uuid, name)
for (name, uuid) in env.project_deps if !Base.in_sysimage(Base.PkgId(uuid, name))
]

# consider exts of direct deps to be direct deps so that errors are reported
append!(direct_deps, keys(filter(d->last(d) in keys(env.project_deps), exts)))

# An extension effectively depends on another extension if it has all the the
# dependencies of that other extension
function expand_dependencies(depsmap)
Expand Down

0 comments on commit 63a10da

Please sign in to comment.